PMD Results

The following document contains the results of PMD 4.2.2.

Files

eParapher Client RCP - org/eparapher/rcp/Activator.java

Violation Line
Avoid unused imports such as 'java.io.File' 3
Avoid unused imports such as 'java.net.MalformedURLException' 5
Avoid unused imports such as 'java.net.URL' 6
Avoid unused imports such as 'org.apache.log4j.Logger' 9
Avoid unused imports such as 'org.eclipse.core.runtime.Platform' 12
Avoid unused imports such as 'org.eparapher.rcp.tools.RCPSettings' 16
Overriding method merely calls super 44 - 56

eParapher Client RCP - org/eparapher/rcp/ApplicationActionBarAdvisor.java

Violation Line
Avoid unused private fields such as 'tokenstatusline'. 87
Avoid unused private fields such as 'oofficestatusline'. 88

eParapher Client RCP - org/eparapher/rcp/ApplicationWorkbenchWindowAdvisor.java

Violation Line
Avoid unused private fields such as 'log'. 23
Avoid unused private fields such as 'inittks'. 28

eParapher Client RCP - org/eparapher/rcp/actions/DecryptAction.java

Violation Line
Avoid unused private fields such as 'usewizard'. 13
These nested if statements could be combined 33 - 40

eParapher Client RCP - org/eparapher/rcp/actions/EncryptAction.java

Violation Line
These nested if statements could be combined 58 - 64

eParapher Client RCP - org/eparapher/rcp/actions/OpenEditorAction.java

Violation Line
Avoid unused imports such as 'org.eparapher.rcp.tools.RCPSettings' 25
Avoid unused private methods such as 'queryFile()'. 81
These nested if statements could be combined 107 - 108

eParapher Client RCP - org/eparapher/rcp/dialog/CertificateRequestViewerDialog.java

Violation Line
Avoid unused local variables such as 'bais'. 72

eParapher Client RCP - org/eparapher/rcp/dialog/CertificateViewerDialog.java

Violation Line
Avoid unused imports such as 'org.eclipse.swt.graphics.FontData' 18
Avoid unused imports such as 'org.eclipse.swt.widgets.Label' 26
Avoid unused method parameters such as 'b'. 436 - 504
An empty statement (semicolon) not part of a loop 571

eParapher Client RCP - org/eparapher/rcp/dialog/PINDialog.java

Violation Line
Avoid unused private fields such as 'panelheight'. 25
Avoid unused private fields such as 'panelwidth'. 26
Avoid unused local variables such as 'message'. 47

eParapher Client RCP - org/eparapher/rcp/dialog/PINORPassphraseDialog.java

Violation Line
Avoid unused local variables such as 'emptylabel'. 176
Avoid unused local variables such as 'len'. 307

eParapher Client RCP - org/eparapher/rcp/editors/BasicMultiPageEditor.java

Violation Line
Avoid unused imports such as 'org.eclipse.ui.IFileEditorInput' 15
Avoid unused imports such as 'org.eclipse.ui.forms.widgets.Form' 20
Avoid unused private fields such as 'font'. 37
Avoid empty if statements 146 - 148

eParapher Client RCP - org/eparapher/rcp/editors/SignatureTabEditor.java

Violation Line
Avoid unused private fields such as 'timeStampValue'. 41

eParapher Client RCP - org/eparapher/rcp/editors/SimpleDocumentProvider.java

Violation Line
Avoid unused imports such as 'org.eparapher.core.crypto.timestamp.TimeStampManager' 27
Avoid unused method parameters such as 'monitor'. 169 - 176

eParapher Client RCP - org/eparapher/rcp/editors/xml/NonRuleBasedDamagerRepairer.java

Violation Line
Avoid empty catch blocks 99 - 100

eParapher Client RCP - org/eparapher/rcp/editors/xml/XMLDoubleClickStrategy.java

Violation Line
Avoid empty catch blocks 67 - 68
Avoid empty catch blocks 105 - 106

eParapher Client RCP - org/eparapher/rcp/preferences/CMSSignaturePreferencePage.java

Violation Line
Avoid unused private fields such as 'cmsinsertCRLs'. 22
Overriding method merely calls super 44 - 46
Overriding method merely calls super 48 - 50

eParapher Client RCP - org/eparapher/rcp/preferences/EParapherPreferencePage.java

Violation Line
Avoid unused private fields such as 'log'. 34

eParapher Client RCP - org/eparapher/rcp/preferences/KeystorePreferencePage.java

Violation Line
Avoid unused private fields such as 'log'. 28

eParapher Client RCP - org/eparapher/rcp/preferences/OpenOfficeEditorPreferences.java

Violation Line
Avoid unused imports such as 'org.eparapher.rcp.tools.RCPSettings' 25
Avoid unused private fields such as 'log'. 34

eParapher Client RCP - org/eparapher/rcp/preferences/PDFSignaturePreferencePage.java

Violation Line
Avoid unused imports such as 'org.eparapher.rcp.tools.RCPSettings' 16
These nested if statements could be combined 125 - 153

eParapher Client RCP - org/eparapher/rcp/preferences/PreferenceInitializer.java

Violation Line
Avoid unused local variables such as 'user'. 33

eParapher Client RCP - org/eparapher/rcp/preferences/SignaturePreferencePage.java

Violation Line
Avoid unused imports such as 'org.eparapher.rcp.tools.RCPSettings' 13
These nested if statements could be combined 71 - 77

eParapher Client RCP - org/eparapher/rcp/preferences/XMLSignaturePreferencePage.java

Violation Line
Avoid unused private fields such as 'log'. 20
These nested if statements could be combined 87 - 105

eParapher Client RCP - org/eparapher/rcp/properties/FileHashPropertyPage.java

Violation Line
Avoid unused private fields such as 'ID'. 47

eParapher Client RCP - org/eparapher/rcp/properties/FilePropertyPage.java

Violation Line
Avoid unused private fields such as 'ID'. 20
Avoid unused private fields such as 'TEXT_FIELD_WIDTH'. 32

eParapher Client RCP - org/eparapher/rcp/tools/CertificateView.java

Violation Line
These nested if statements could be combined 184 - 188

eParapher Client RCP - org/eparapher/rcp/tools/RCPSettings.java

Violation Line
Avoid unused private methods such as 'getRCPFloat(String)'. 29

eParapher Client RCP - org/eparapher/rcp/tray/TrayIconManager.java

Violation Line
Avoid unused private fields such as 'started'. 23

eParapher Client RCP - org/eparapher/rcp/views/AbstractCertificateView.java

Violation Line
Avoid empty if statements 327 - 329

eParapher Client RCP - org/eparapher/rcp/views/CryptoProvidersView.java

Violation Line
Avoid unused method parameters such as 'manager'. 264 - 265

eParapher Client RCP - org/eparapher/rcp/views/DebugConsoleView.java

Violation Line
Avoid unused private fields such as 'log'. 25

eParapher Client RCP - org/eparapher/rcp/views/TrustedCertificateStoreView.java

Violation Line
These nested if statements could be combined 163 - 176
Avoid unnecessary return statements 178

eParapher Client RCP - org/eparapher/rcp/views/documents/SecuredDocumentsView.java

Violation Line
Avoid unused imports such as 'org.eclipse.jface.viewers.ISelectionProvider' 15
Avoid unused private fields such as 'decryptwithwizardAction'. 84
Avoid unused private fields such as 'isReadableDir'. 104
Avoid unused constructor parameters such as 'misReadableDir'. 111 - 114
Avoid unused private fields such as 'rootnb'. 150
These nested if statements could be combined 324 - 335
Avoid empty if statements 351 - 353

eParapher Client RCP - org/eparapher/rcp/wizards/CMSSigningWizard.java

Violation Line
Avoid unused private fields such as 'log'. 14
Avoid unused private fields such as 'window'. 17

eParapher Client RCP - org/eparapher/rcp/wizards/ExportKeysCertificatesWizard.java

Violation Line
Avoid unused private fields such as 'window'. 18
Avoid unused private fields such as 'userCert'. 23

eParapher Client RCP - org/eparapher/rcp/wizards/ImportKeysCertificatesWizard.java

Violation Line
Avoid unused private fields such as 'window'. 26

eParapher Client RCP - org/eparapher/rcp/wizards/ImportKeysCertificatesWizardPageTwo.java

Violation Line
Avoid unused imports such as 'org.eclipse.jface.viewers.ISelectionChangedListener' 20
Avoid unused imports such as 'org.eclipse.jface.viewers.SelectionChangedEvent' 21
Avoid unused imports such as 'org.eparapher.core.EParapherManager' 35
These nested if statements could be combined 212 - 219

eParapher Client RCP - org/eparapher/rcp/wizards/KeysAndCertificateSelectionPage.java

Violation Line
Avoid unused imports such as 'org.eclipse.swt.widgets.TableItem' 24
These nested if statements could be combined 209 - 213

eParapher Client RCP - org/eparapher/rcp/wizards/KeysAndFormatWizardPage.java

Violation Line
Avoid unused local variables such as 'emptylabel'. 77
These nested if statements could be combined 134 - 139
These nested if statements could be combined 142 - 147
These nested if statements could be combined 174 - 175

eParapher Client RCP - org/eparapher/rcp/wizards/NewCertificateWizard.java

Violation Line
Avoid unused private fields such as 'window'. 35

eParapher Client RCP - org/eparapher/rcp/wizards/NewCertificateWizardPageOne.java

Violation Line
Avoid unused private fields such as 'log'. 37
These nested if statements could be combined 333 - 334

eParapher Client RCP - org/eparapher/rcp/wizards/PDFSigningWizard.java

Violation Line
Avoid unused private fields such as 'log'. 13
Avoid unused private fields such as 'window'. 16

eParapher Client RCP - org/eparapher/rcp/wizards/PinOrPassphraseWizardPage.java

Violation Line
Avoid unused imports such as 'org.eclipse.swt.layout.FillLayout' 5
Avoid unused imports such as 'org.eparapher.rcp.tools.RCPSettings' 22

eParapher Client RCP - org/eparapher/rcp/wizards/SelectFilesPage.java

Violation Line
Avoid unused imports such as 'org.eparapher.rcp.tools.RCPSettings' 35
Avoid unused constructor parameters such as 'pageName'. 51 - 61

eParapher Client RCP - org/eparapher/rcp/wizards/XMLSigningWizard.java

Violation Line
Avoid unused private fields such as 'log'. 14
Avoid unused private fields such as 'window'. 17

eParapher Client RCP - org/eparapher/rcp/wizards/XMLSigningWizardPageOne.java

Violation Line
Avoid unused private fields such as 'log'. 8

eParapher Client RCP - org/eparapher/rcp/wizards/XMLSigningWizardPageTwo.java

Violation Line
Avoid unused private fields such as 'log'. 8

eParapher Core Library - org/eparapher/core/crypto/EPDigestManager.java

Violation Line
Avoid unused private fields such as 'log'. 12
Avoid unused private fields such as 'mds'. 36

eParapher Core Library - org/eparapher/core/crypto/JCEPolicyTest.java

Violation Line
Avoid unused private methods such as 'testPolicyRestrictionsForAllAlgorithms()'. 72
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 108
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 110

eParapher Core Library - org/eparapher/core/crypto/KeystoreEntry.java

Violation Line
Ensure you override both equals() and hashCode() 60
These nested if statements could be combined 66 - 70
These nested if statements could be combined 72 - 80
These nested if statements could be combined 73 - 79

eParapher Core Library - org/eparapher/core/crypto/cert/CertificateInfo.java

Violation Line
Avoid unused private fields such as 'issuerdnfieldextractor'. 133
Avoid unused private fields such as 'subjectdnfieldextractor'. 133
Avoid unused private fields such as 'subjectdirattrstring'. 135

eParapher Core Library - org/eparapher/core/crypto/cert/CertificateManager.java

Violation Line
Avoid unused imports such as 'java.security.Signature' 23
Avoid unused imports such as 'java.security.cert.CertSelector' 31
Avoid unused imports such as 'org.bouncycastle.cms.CMSSignedGenerator' 81
Avoid unused local variables such as 'cpvResult'. 498
Avoid unused private methods such as 'validateReply(KeyStore,KeyStore,String,X509Certificate,List,boolean,boolean)'. 630 - 632
Avoid empty catch blocks 704 - 706
These nested if statements could be combined 791 - 792

eParapher Core Library - org/eparapher/core/crypto/cert/NewCertParams.java

Violation Line
Avoid unused private fields such as 'extkeyusage'. 20

eParapher Core Library - org/eparapher/core/crypto/cert/X509Util.java

Violation Line
Avoid unused imports such as 'java.io.DataOutputStream' 6
Avoid unused private fields such as 'X509_CERT_TYPE'. 76
Avoid unused private fields such as 'PKCS7_ENCODING'. 77
Avoid unused private methods such as 'getStringFromGeneralNames(DERObject)'. 345
These nested if statements could be combined 427 - 430

eParapher Core Library - org/eparapher/core/crypto/keystore/EPKeystoreUtils.java

Violation Line
Avoid unused imports such as 'org.eparapher.core.crypto.KeystoreEntry' 14

eParapher Core Library - org/eparapher/core/crypto/keystore/FileKeystore.java

Violation Line
These nested if statements could be combined 169 - 170
These nested if statements could be combined 289 - 291

eParapher Core Library - org/eparapher/core/crypto/keystore/GenericKeystore.java

Violation Line
These nested if statements could be combined 44 - 45
Avoid unused method parameters such as 'currentCertChain'. 133 - 136
These nested if statements could be combined 170 - 188

eParapher Core Library - org/eparapher/core/crypto/keystore/HardwareKeyStore.java

Violation Line
Avoid unused private methods such as 'validatePIN(String)'. 92

eParapher Core Library - org/eparapher/core/crypto/keystore/MSCAPIKeystore.java

Violation Line
These nested if statements could be combined 42 - 43

eParapher Core Library - org/eparapher/core/crypto/timestamp/TimeStampManager.java

Violation Line
Avoid unused private methods such as 'addTimestamp(CMSSignedData)'. 65
Avoid unused private fields such as 'KEYSTORE_PASSWORD'. 170

eParapher Core Library - org/eparapher/core/crypto/tools/PasswordPolicyManager.java

Violation Line
These nested if statements could be combined 76 - 77
These nested if statements could be combined 80 - 81
These nested if statements could be combined 84 - 85
These nested if statements could be combined 88 - 89
These nested if statements could be combined 92 - 93

eParapher Core Library - org/eparapher/core/encryption/CMSEncryption.java

Violation Line
Avoid unused private fields such as 'userpkandcert'. 26
Avoid unused method parameters such as 'cmsencparams'. 76 - 78

eParapher Core Library - org/eparapher/core/exceptions/SignatureException.java

Violation Line
Avoid unused private fields such as 'fileToSign'. 5

eParapher Core Library - org/eparapher/core/signature/CMSSigner.java

Violation Line
Avoid unused local variables such as 'ci'. 80
Avoid unused method parameters such as 'cmssignparams'. 117 - 134

eParapher Core Library - org/eparapher/core/signature/XMLSigner.java

Violation Line
These nested if statements could be combined 84 - 85
Avoid unused method parameters such as 'xmlsignparams'. 92 - 139

eParapher Core Library - org/eparapher/core/tools/ClamavUtils.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 196
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 356

eParapher Core Library - org/eparapher/core/tools/FileUtil.java

Violation Line
Avoid unused local variables such as 'filesize'. 143

eParapher Core Library - org/eparapher/core/tools/OODaemonManager.java

Violation Line
Avoid unused imports such as 'java.io.FileNotFoundException' 5

eParapher Core Library - org/eparapher/core/tools/PDFConverterWrapper.java

Violation Line
Avoid unused local variables such as 'eLabel'. 146
Avoid unused local variables such as 'docWriter'. 215
Avoid unused local variables such as 'contents'. 231